Fix tmc integration test - Wait for shiny app idle after fit is clicked #1296
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 70 suites 1h 8m 52s ⏱️ Results for commit a2da0c5. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit bd86cae ♻️ This comment has been updated with latest results. |
averissimo
approved these changes
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially closes #1258
Potentially, because I was not able to reproduce this issue in any way to know for sure that fixes the issue. I tested in macOS, linux (docker image our CI uses), and Windows machines after installing all the packages from the GitHub main branch and was unable to reproduce this behavior.
We can close the issue after we confirm the daily integration test is resolved.
Rationale for the change:
Since this module only works after the
Fit Modelbutton is clicked the shinytest2 logic goes as follows:TealAppDriverobject using thetm_a_mmrm()module.Fit Modelbutton.a. Select the
Output Typeb. Check for errors
c. Check if output changed
I think that when we start checking for errors we spot the validation error before the output had time to render because the output type we want to select is in the first selection, which is pre-selected, and since we do not wait for input changes when the input is the same, we quickly start checking for errors and observe the validation error.
If, this is the case, this PR will fix it.